blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEscapedCharacters.pm

filter: Statementstmt 96.9% 32 / 33 Branchbran 50.0% 1 / 2 Conditioncond n/a MC/DCmcdc n/a Subroutinesub 100% 11 / 11 Podpod 80.0% 4 / 5 totaltotal 94.1% 48 / 51 CC 2 SCAR 1.6
CC
2
Cov
94%
violates
2.0
BEGIN
1.0
BEGIN
1.0
CRAP 1.2
« blib/lib/Perl/Critic/Policy/Variables/ProtectPrivateVars.pm ↑ Summary blib/lib/Perl/Critic/Exception/Configuration/NonExistentPolicy.pm »
1 package Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters;
2  
3 40 ▶use 5.010001;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 40 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 40 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
6 40 ▶use Readonly;
Subroutine BEGIN: called CC=1 SCAR=0.0
7  
8 40 ▶use Perl::Critic::Utils qw{ :severities };
Subroutine BEGIN: called CC=1 SCAR=0.0
9 40 ▶use parent 'Perl::Critic::Policy';
Subroutine BEGIN: called CC=1 SCAR=0.0
10  
11 40 our $VERSION = '1.150';
12  
13 #-----------------------------------------------------------------------------
14  
15 40 Readonly::Scalar my $DESC => q{Numeric escapes in interpolated string};
16 40 Readonly::Scalar my $EXPL => [ 54..55 ];
17  
18 #-----------------------------------------------------------------------------
19  
20 90 ▶sub supported_parameters { return () }
Subroutine supported_parameters: called CC=1 SCAR=0.0
Pod undocumented
21 75 ▶sub default_severity { return $SEVERITY_LOW }
Subroutine default_severity: called CC=1 SCAR=0.0
Pod documented
22 84 ▶sub default_themes { return qw(core pbp cosmetic) }
Subroutine default_themes: called CC=1 SCAR=0.0
Pod documented
23 31 ▶sub applies_to { return qw(PPI::Token::Quote::Double
Subroutine applies_to: called CC=1 SCAR=0.0
Pod documented
24 PPI::Token::Quote::Interpolate) }
25  
26 #-----------------------------------------------------------------------------
27  
28 sub violates {
29 1 ▶ my ( $self, $elem, undef ) = @_;
Subroutine violates: called CC=2 SCAR=7.1
Pod documented
30  
31 1 my $not_escaped = qr/(?<!\\)(?:\\\\)*/xms;
32 1 my $hex = qr/\\x[\dA-Fa-f]{2}/xms;
33 1 my $widehex = qr/\\x[{][\dA-Fa-f]+[}]/xms;
34 1 my $oct = qr/\\[01][0-7]/xms;
35 1 ▶ if ($elem->content =~ m/$not_escaped (?:$hex|$widehex|$oct)/xmso) {
Branch: 1 branch
BranchTrueFalseTotal
if ($elem->content =~ /$not_escaped (?:$hex|$widehex|$oct)/mosx) 0 1 1
36 0 return $self->violation( $DESC, $EXPL, $elem );
37 }
38 1 return; #ok!
39 }
40  
41 40 1;
42  
43 __END__
44  
45 #-----------------------------------------------------------------------------
46  
47 =pod
48  
49 =head1 NAME
50  
51 Perl::Critic::Policy::ValuesAndExpressions::ProhibitEscapedCharacters - Write C<"\N{DELETE}"> instead of C<"\x7F">, etc.
52  
53 =head1 AFFILIATION
54  
55 This Policy is part of the core L<Perl::Critic|Perl::Critic>
56 distribution.
57  
58  
59 =head1 DESCRIPTION
60  
61 Escaped numeric values are hard to read and debug. Instead, use named
62 values. The syntax is less compact, but dramatically more readable.
63  
64 $str = "\x7F\x06\x22Z"; # not ok
65  
66 use charnames ':full';
67 $str = "\N{DELETE}\N{ACKNOWLEDGE}\N{CANCEL}Z"; # ok
68  
69  
70 =head1 CONFIGURATION
71  
72 This Policy is not configurable except for the standard options.
73  
74  
75 =head1 AUTHOR
76  
77 Chris Dolan <cdolan@cpan.org>
78  
79 =head1 COPYRIGHT
80  
81 Copyright (c) 2006-2011 Chris Dolan.
82  
83 This program is free software; you can redistribute it and/or modify
84 it under the same terms as Perl itself. The full text of this license
85 can be found in the LICENSE file included with this module.
86  
87 =cut
88  
89 # Local Variables:
90 # mode: cperl
91 # cperl-indent-level: 4
92 # fill-column: 78
93 # indent-tabs-mode: nil
94 # c-indentation-style: bsd
95 # End:
96 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
« blib/lib/Perl/Critic/Policy/Variables/ProtectPrivateVars.pm ↑ Summary blib/lib/Perl/Critic/Exception/Configuration/NonExistentPolicy.pm »