blib/lib/Perl/Critic/Policy/TestingAndDebugging/ProhibitNoStrict.pm

filter: Statementstmt 80.4% 37 / 46 Branchbran 25.0% 3 / 12 Conditioncond 0.0% 0 / 6 MC/DCmcdc 0.0% 0 / 4 Subroutinesub 92.8% 13 / 14 Podpod 80.0% 4 / 5 totaltotal 65.5% 57 / 87 CC 9 SCAR 30.0
CC
9
Cov
62%
violates
52.9
_parse_allow
2.0
__ANON__
2.0
CRAP 20.0
« blib/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUselessTopic.pm ↑ Summary blib/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm »
1 package Perl::Critic::Policy::TestingAndDebugging::ProhibitNoStrict;
2  
3 40 ▶use 5.010001;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 40 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 40 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
6 40 ▶use Readonly;
Subroutine BEGIN: called CC=1 SCAR=0.0
7  
8 40 ▶use List::SomeUtils qw(all);
Subroutine BEGIN: called CC=1 SCAR=0.0
9  
10 40 ▶use Perl::Critic::Utils qw{ :characters :severities :data_conversion };
Subroutine BEGIN: called CC=1 SCAR=0.0
11 40 ▶use parent 'Perl::Critic::Policy';
Subroutine BEGIN: called CC=1 SCAR=0.0
12  
13 40 our $VERSION = '1.150';
14  
15 #-----------------------------------------------------------------------------
16  
17 40 Readonly::Scalar my $DESC => q{Stricture disabled};
18 40 Readonly::Scalar my $EXPL => [ 429 ];
19  
20 #-----------------------------------------------------------------------------
21  
22 sub supported_parameters {
23 return (
24 {
25 91 ▶ name => 'allow',
Subroutine supported_parameters: called CC=1 SCAR=0.0
Pod undocumented
26 description => 'Allow vars, subs, and/or refs.',
27 default_string => $EMPTY,
28 parser => \&_parse_allow,
29 },
30 );
31 }
32  
33 75 ▶sub default_severity { return $SEVERITY_HIGHEST }
Subroutine default_severity: called CC=1 SCAR=0.0
Pod documented
34 92 ▶sub default_themes { return qw( core pbp bugs certrec ) }
Subroutine default_themes: called CC=1 SCAR=0.0
Pod documented
35 37 ▶sub applies_to { return 'PPI::Statement::Include' }
Subroutine applies_to: called CC=1 SCAR=0.0
Pod documented
36  
37 #-----------------------------------------------------------------------------
38  
39 sub _parse_allow {
40 89 ▶ my ($self, $parameter, $config_string) = @_;
Subroutine _parse_allow: called CC=2 SCAR=6.9
41  
42 89 $self->{_allow} = {};
43  
44 89 ▶ if( defined $config_string ) {
Branch: 1 branch
BranchTrueFalseTotal
if (defined $config_string) 2 87 89
45 2 my $allowed = lc $config_string; #String of words
46 2 my %allowed = hashify( $allowed =~ m/ (\w+) /gxms );
47 2 $self->{_allow} = \%allowed;
48 }
49  
50 89 return;
51 }
52  
53 #-----------------------------------------------------------------------------
54  
55 sub violates {
56 63 ▶ my ( $self, $elem, undef ) = @_;
Subroutine violates: called CC=8 SCAR=39.7
Pod documented
57  
58 63 ▶ return if $elem->type() ne 'no';
Branch: 1 branch
BranchTrueFalseTotal
if $elem->type ne "no" 63 0 63
59 0 ▶ return if $elem->pragma() ne 'strict';
Branch: 1 branch
BranchTrueFalseTotal
if $elem->pragma ne "strict" 0 0 0
60  
61 #Arguments to 'no strict' are usually a list of literals or a qw()
62 #list. Rather than trying to parse the various PPI elements, I
63 #just use a regex to split the statement into words. This is
64 #kinda lame, but it does the trick for now.
65  
66 # TODO consider: a possible alternate implementation:
67 # my $re = join q{|}, keys %{$self->{allow}};
68 # return if $re && $stmnt =~ m/\b(?:$re)\b/mx;
69 # May need to detaint for that to work... Not sure.
70  
71 0 my $stmnt = $elem->statement();
72 0 ▶ return if !$stmnt;
Branch: 1 branch
BranchTrueFalseTotal
unless $stmnt 0 0 0
73 0 my @words = $stmnt =~ m/ ([[:lower:]]+) /gxms;
74 0 ▶ @words = grep { $_ ne 'qw' && $_ ne 'no' && $_ ne 'strict' } @words;
Branch: 1 branch
BranchTrueFalseTotal
$_ ne "qw" and $_ ne "no" and $_ ne "strict" 0 0 0
Condition0%0/3
$_ ne "qw" and $_ ne "no"
!ll&&!rl&&r
000
MC/DC0%0/2
$_ ne "qw" and $_ ne "no"
$_ ne "qw" $_ ne "no"
Truth table0%0/3
A and B
A= $_ ne "qw"B= $_ ne "no"
ABresult
0X0
100
111
75 0 ▶ return if @words && all { exists $self->{_allow}->{$_} } @words;
Subroutine __ANON__: not called CC=1 SCAR=6.9
Branch: 1 branch
BranchTrueFalseTotal
if @words and &all(sub { exists $self->{"_allow"}{$_}; } , @words) 0 0 0
Condition0%0/3
@words and &all(sub {
!ll&&!rl&&r
000
MC/DC0%0/2
@words and &all(sub { exists $self->{"_allow"}{$_}; } , @words)
@words &all(sub { exists $self->{"_allow"}{$_}; } , @words)
Truth table0%0/3
A and B
A= @wordsB= &all(sub { exists $self->{"_allow"}{$_}; } , @words)
ABresult
0X0
100
111
76  
77 #If we get here, then it must be a violation
78 0 return $self->violation( $DESC, $EXPL, $elem );
79 }
80  
81 40 1;
82  
83 __END__
84  
85 #-----------------------------------------------------------------------------
86  
87 =pod
88  
89 =head1 NAME
90  
91 Perl::Critic::Policy::TestingAndDebugging::ProhibitNoStrict - Prohibit various flavors of C<no strict>.
92  
93  
94 =head1 AFFILIATION
95  
96 This Policy is part of the core L<Perl::Critic|Perl::Critic>
97 distribution.
98  
99  
100 =head1 DESCRIPTION
101  
102 There are good reasons for disabling certain kinds of strictures, But
103 if you were wise enough to C<use strict> in the first place, then it
104 doesn't make sense to disable it completely. By default, any C<no
105 strict> statement will violate this policy. However, you can
106 configure this Policy to allow certain types of strictures to be
107 disabled (See L</CONFIGURATION>). A bare C<no strict> statement will
108 always raise a violation.
109  
110  
111 =head1 CONFIGURATION
112  
113 The permitted strictures can be configured via the C<allow> option.
114 The value is a list of whitespace-delimited stricture types that you
115 want to permit. These can be C<vars>, C<subs> and/or C<refs>. An
116 example of this customization:
117  
118 [TestingAndDebugging::ProhibitNoStrict]
119 allow = vars subs refs
120  
121  
122 =head1 SEE ALSO
123  
124 L<Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict|Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict>
125  
126  
127 =head1 AUTHOR
128  
129 Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
130  
131  
132 =head1 COPYRIGHT
133  
134 Copyright (c) 2005-2021 Imaginative Software Systems. All rights reserved.
135  
136 This program is free software; you can redistribute it and/or modify
137 it under the same terms as Perl itself. The full text of this license
138 can be found in the LICENSE file included with this module
139  
140 =cut
141  
142 ##############################################################################
143 # Local Variables:
144 # mode: cperl
145 # cperl-indent-level: 4
146 # fill-column: 78
147 # indent-tabs-mode: nil
148 # c-indentation-style: bsd
149 # End:
150 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
« blib/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitUselessTopic.pm ↑ Summary blib/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm »