blib/lib/Perl/Critic/Policy/InputOutput/ProhibitOneArgSelect.pm

filter: Statementstmt 84.3% 27 / 32 Branchbran 16.6% 1 / 6 Conditioncond n/a MC/DCmcdc n/a Subroutinesub 100% 11 / 11 Podpod 80.0% 4 / 5 totaltotal 79.6% 43 / 54 CC 4 SCAR 13.7
CC
4
Cov
74%
violates
11.3
BEGIN
1.0
BEGIN
1.0
CRAP 3.9
« blib/lib/Perl/Critic/Policy/Subroutines/ProhibitBuiltinHomonyms.pm ↑ Summary blib/lib/Perl/Critic/Policy/Variables/ProhibitPackageVars.pm »
1 package Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect;
2  
3 40 ▶use 5.010001;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 40 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 40 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
6 40 ▶use Readonly;
Subroutine BEGIN: called CC=1 SCAR=0.0
7  
8 40 ▶use Perl::Critic::Utils qw{ :severities :classification :ppi };
Subroutine BEGIN: called CC=1 SCAR=0.0
9 40 ▶use parent 'Perl::Critic::Policy';
Subroutine BEGIN: called CC=1 SCAR=0.0
10  
11 40 our $VERSION = '1.150';
12  
13 #-----------------------------------------------------------------------------
14  
15 40 Readonly::Scalar my $DESC => q{One-argument "select" used};
16 40 Readonly::Scalar my $EXPL => [ 224 ];
17  
18 #-----------------------------------------------------------------------------
19  
20 90 ▶sub supported_parameters { return () }
Subroutine supported_parameters: called CC=1 SCAR=0.0
Pod undocumented
21 75 ▶sub default_severity { return $SEVERITY_HIGH }
Subroutine default_severity: called CC=1 SCAR=0.0
Pod documented
22 92 ▶sub default_themes { return qw( core bugs pbp certrule ) }
Subroutine default_themes: called CC=1 SCAR=0.0
Pod documented
23 33 ▶sub applies_to { return 'PPI::Token::Word' }
Subroutine applies_to: called CC=1 SCAR=0.0
Pod documented
24  
25 #-----------------------------------------------------------------------------
26  
27 sub violates {
28 349 ▶ my ($self, $elem, undef) = @_;
Subroutine violates: called CC=4 SCAR=24.2
Pod documented
29  
30 349 ▶ return if $elem->content() ne 'select';
Branch: 1 branch
BranchTrueFalseTotal
if $elem->content ne "select" 349 0 349
31 0 ▶ return if ! is_function_call($elem);
Branch: 1 branch
BranchTrueFalseTotal
unless is_function_call($elem) 0 0 0
32  
33 0 my @arguments = parse_arg_list($elem);
34 0 ▶ if( 1 == @arguments ) {
Branch: 1 branch
BranchTrueFalseTotal
if (1 == @arguments) 0 0 0
35 0 return $self->violation( $DESC, $EXPL, $elem );
36 }
37 0 return; #ok!
38 }
39  
40 40 1;
41  
42 __END__
43  
44 #-----------------------------------------------------------------------------
45  
46 =pod
47  
48 =head1 NAME
49  
50 Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect - Never write C<select($fh)>.
51  
52 =head1 AFFILIATION
53  
54 This Policy is part of the core L<Perl::Critic|Perl::Critic>
55 distribution.
56  
57  
58 =head1 DESCRIPTION
59  
60 Conway discourages the use of a raw C<select()> when setting
61 autoflushes. We'll extend that further by simply prohibiting the
62 one-argument form of C<select()> entirely; if you really need it you
63 should know when/where/why that is. For performing autoflushes,
64 Conway recommends the use of C<IO::Handle> instead.
65  
66 select((select($fh), $|=1)[0]); # not ok
67 select $fh; # not ok
68  
69 use IO::Handle;
70 $fh->autoflush(); # ok
71 *STDOUT->autoflush(); # ok
72  
73  
74 =head1 CONFIGURATION
75  
76 This Policy is not configurable except for the standard options.
77  
78  
79 =head1 SEE ALSO
80  
81 L<IO::Handle|IO::Handle>.
82  
83 =head1 AUTHOR
84  
85 Graham TerMarsch <graham@howlingfrog.com>
86  
87 =head1 COPYRIGHT
88  
89 Copyright (c) 2005-2011 Graham TerMarsch. All rights reserved.
90  
91 This program is free software; you can redistribute it and/or modify
92 it under the same terms as Perl itself.
93  
94 =cut
95  
96 # Local Variables:
97 # mode: cperl
98 # cperl-indent-level: 4
99 # fill-column: 78
100 # indent-tabs-mode: nil
101 # c-indentation-style: bsd
102 # End:
103 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
« blib/lib/Perl/Critic/Policy/Subroutines/ProhibitBuiltinHomonyms.pm ↑ Summary blib/lib/Perl/Critic/Policy/Variables/ProhibitPackageVars.pm »