blib/lib/Perl/Critic/Policy/ControlStructures/ProhibitUnlessBlocks.pm

filter: Statementstmt 100% 29 / 29 Branchbran 100% 2 / 2 Conditioncond n/a MC/DCmcdc n/a Subroutinesub 100% 11 / 11 Podpod 80.0% 4 / 5 totaltotal 97.8% 46 / 47 CC 2 SCAR 1.5
CC
2
Cov
100%
violates
2.0
BEGIN
1.0
BEGIN
1.0
CRAP 1.2
« blib/lib/Perl/Critic/Exception/Configuration/NonExistentPolicy.pm ↑ Summary blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEmptyQuotes.pm »
1 package Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks;
2  
3 40 ▶use 5.010001;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 40 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 40 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
6 40 ▶use Readonly;
Subroutine BEGIN: called CC=1 SCAR=0.0
7  
8 40 ▶use Perl::Critic::Utils qw{ :severities };
Subroutine BEGIN: called CC=1 SCAR=0.0
9 40 ▶use parent 'Perl::Critic::Policy';
Subroutine BEGIN: called CC=1 SCAR=0.0
10  
11 40 our $VERSION = '1.150';
12  
13 #-----------------------------------------------------------------------------
14  
15 40 Readonly::Scalar my $DESC => q{"unless" block used};
16 40 Readonly::Scalar my $EXPL => [ 97 ];
17  
18 #-----------------------------------------------------------------------------
19  
20 90 ▶sub supported_parameters { return () }
Subroutine supported_parameters: called CC=1 SCAR=0.0
Pod undocumented
21 77 ▶sub default_severity { return $SEVERITY_LOW }
Subroutine default_severity: called CC=1 SCAR=0.0
Pod documented
22 84 ▶sub default_themes { return qw(core pbp cosmetic) }
Subroutine default_themes: called CC=1 SCAR=0.0
Pod documented
23 31 ▶sub applies_to { return 'PPI::Statement::Compound' }
Subroutine applies_to: called CC=1 SCAR=0.0
Pod documented
24  
25 #-----------------------------------------------------------------------------
26  
27 sub violates {
28 11 ▶ my ( $self, $elem, undef ) = @_;
Subroutine violates: called CC=2 SCAR=6.9
Pod documented
29  
30 11 ▶ if ( $elem->first_element() eq 'unless' ) {
Branch: 1 branch
BranchTrueFalseTotal
if ($elem->first_element eq "unless") 2 9 11
31 2 return $self->violation( $DESC, $EXPL, $elem );
32 }
33 9 return; #ok!
34 }
35  
36 40 1;
37  
38 __END__
39  
40 #-----------------------------------------------------------------------------
41  
42 =pod
43  
44 =head1 NAME
45  
46 Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks - Write C<if(! $condition)> instead of C<unless($condition)>.
47  
48 =head1 AFFILIATION
49  
50 This Policy is part of the core L<Perl::Critic|Perl::Critic>
51 distribution.
52  
53  
54 =head1 DESCRIPTION
55  
56 Conway discourages using C<unless> because it leads to
57 double-negatives that are hard to understand. Instead, reverse the
58 logic and use C<if>.
59  
60 unless($condition) { do_something() } #not ok
61 unless(! $no_flag) { do_something() } #really bad
62 if( ! $condition) { do_something() } #ok
63  
64 This Policy only covers the block-form of C<unless>. For the postfix
65 variety, see C<ProhibitPostfixControls>.
66  
67  
68 =head1 CONFIGURATION
69  
70 This Policy is not configurable except for the standard options.
71  
72  
73 =head1 SEE ALSO
74  
75 L<Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls|Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls>
76  
77 =head1 AUTHOR
78  
79 Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
80  
81 =head1 COPYRIGHT
82  
83 Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
84  
85 This program is free software; you can redistribute it and/or modify
86 it under the same terms as Perl itself. The full text of this license
87 can be found in the LICENSE file included with this module.
88  
89 =cut
90  
91 # Local Variables:
92 # mode: cperl
93 # cperl-indent-level: 4
94 # fill-column: 78
95 # indent-tabs-mode: nil
96 # c-indentation-style: bsd
97 # End:
98 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
« blib/lib/Perl/Critic/Exception/Configuration/NonExistentPolicy.pm ↑ Summary blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEmptyQuotes.pm »