blib/lib/Perl/Critic/Policy/ControlStructures/ProhibitCStyleForLoops.pm

filter: Statementstmt 97.2% 35 / 36 Branchbran 50.0% 2 / 4 Conditioncond n/a MC/DCmcdc n/a Subroutinesub 100% 12 / 12 Podpod 80.0% 4 / 5 totaltotal 92.9% 53 / 57 CC 3 SCAR 2.7
CC
3
Cov
92%
violates
2.1
_is_cstyle
2.0
BEGIN
1.0
CRAP 1.3
« blib/lib/Perl/Critic/Exception/Configuration/Option.pm ↑ Summary blib/lib/Perl/Critic/Exception/Configuration/Option/Global/ExtraParameter.pm »
1 package Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops;
2  
3 40 ▶use 5.010001;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 40 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 40 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
6 40 ▶use Readonly;
Subroutine BEGIN: called CC=1 SCAR=0.0
7  
8 40 ▶use Perl::Critic::Utils qw{ :characters :severities };
Subroutine BEGIN: called CC=1 SCAR=0.0
9 40 ▶use parent 'Perl::Critic::Policy';
Subroutine BEGIN: called CC=1 SCAR=0.0
10  
11 40 our $VERSION = '1.150';
12  
13 #-----------------------------------------------------------------------------
14  
15 40 Readonly::Scalar my $DESC => q{C-style "for" loop used};
16 40 Readonly::Scalar my $EXPL => [ 100 ];
17  
18 #-----------------------------------------------------------------------------
19  
20 90 ▶sub supported_parameters { return () }
Subroutine supported_parameters: called CC=1 SCAR=0.0
Pod undocumented
21 77 ▶sub default_severity { return $SEVERITY_LOW }
Subroutine default_severity: called CC=1 SCAR=0.0
Pod documented
22 86 ▶sub default_themes { return qw( core pbp maintenance ) }
Subroutine default_themes: called CC=1 SCAR=0.0
Pod documented
23 31 ▶sub applies_to { return 'PPI::Structure::For' }
Subroutine applies_to: called CC=1 SCAR=0.0
Pod documented
24  
25 #-----------------------------------------------------------------------------
26  
27 sub violates {
28 2 ▶ my ( $self, $elem, undef ) = @_;
Subroutine violates: called CC=2 SCAR=7.6
Pod documented
29  
30 2 ▶ if ( _is_cstyle($elem) ) {
Branch: 1 branch
BranchTrueFalseTotal
if (_is_cstyle($elem)) 2 0 2
31 2 return $self->violation( $DESC, $EXPL, $elem );
32 }
33 0 return; #ok!
34 }
35  
36 sub _is_cstyle {
37 2 ▶ my $elem = shift;
Subroutine _is_cstyle: called CC=2 SCAR=7.0
38 2 my $nodes_ref = $elem->find('PPI::Token::Structure');
39 2 ▶ return if !$nodes_ref;
Branch: 1 branch
BranchTrueFalseTotal
unless $nodes_ref 0 2 2
40 2 my @semis = grep { $_ eq $SCOLON } @{$nodes_ref};
41 2 return scalar @semis == 2;
42 }
43  
44 40 1;
45  
46 __END__
47  
48 #-----------------------------------------------------------------------------
49  
50 =pod
51  
52 =head1 NAME
53  
54 Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops - Write C<for(0..20)> instead of C<for($i=0; $i<=20; $i++)>.
55  
56 =head1 AFFILIATION
57  
58 This Policy is part of the core L<Perl::Critic|Perl::Critic>
59 distribution.
60  
61  
62 =head1 DESCRIPTION
63  
64 The 3-part C<for> loop that Perl inherits from C is butt-ugly, and
65 only really necessary if you need irregular counting. The very
66 Perlish C<..> operator is much more elegant and readable.
67  
68 for($i=0; $i<=$max; $i++){ #ick!
69 do_something($i);
70 }
71  
72 for(0..$max){ #very nice
73 do_something($_);
74 }
75  
76  
77 =head1 CONFIGURATION
78  
79 This Policy is not configurable except for the standard options.
80  
81  
82 =head1 AUTHOR
83  
84 Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
85  
86 =head1 COPYRIGHT
87  
88 Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
89  
90 This program is free software; you can redistribute it and/or modify
91 it under the same terms as Perl itself. The full text of this license
92 can be found in the LICENSE file included with this module.
93  
94 =cut
95  
96 # Local Variables:
97 # mode: cperl
98 # cperl-indent-level: 4
99 # fill-column: 78
100 # indent-tabs-mode: nil
101 # c-indentation-style: bsd
102 # End:
103 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
« blib/lib/Perl/Critic/Exception/Configuration/Option.pm ↑ Summary blib/lib/Perl/Critic/Exception/Configuration/Option/Global/ExtraParameter.pm »