blib/lib/Perl/Critic/Policy/ClassHierarchies/ProhibitOneArgBless.pm

filter: Statementstmt 87.1% 27 / 31 Branchbran 16.6% 1 / 6 Conditioncond n/a MC/DCmcdc n/a Subroutinesub 100% 11 / 11 Podpod 80.0% 4 / 5 totaltotal 81.1% 43 / 53 CC 4 SCAR 13.3
CC
4
Cov
76%
violates
10.8
BEGIN
1.0
BEGIN
1.0
CRAP 3.8
« blib/lib/Perl/Critic/Policy/Modules/RequireExplicitPackage.pm ↑ Summary blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMixedBooleanOperators.pm »
1 package Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless;
2  
3 40 ▶use 5.010001;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 40 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 40 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
6 40 ▶use Readonly;
Subroutine BEGIN: called CC=1 SCAR=0.0
7  
8 40 ▶use Perl::Critic::Utils qw( :severities :classification :ppi );
Subroutine BEGIN: called CC=1 SCAR=0.0
9 40 ▶use parent 'Perl::Critic::Policy';
Subroutine BEGIN: called CC=1 SCAR=0.0
10  
11 40 our $VERSION = '1.150';
12  
13 #-----------------------------------------------------------------------------
14  
15 40 Readonly::Scalar my $DESC => q{One-argument "bless" used};
16 40 Readonly::Scalar my $EXPL => [ 365 ];
17  
18 #-----------------------------------------------------------------------------
19  
20 90 ▶sub supported_parameters { return () }
Subroutine supported_parameters: called CC=1 SCAR=0.0
Pod undocumented
21 75 ▶sub default_severity { return $SEVERITY_HIGHEST }
Subroutine default_severity: called CC=1 SCAR=0.0
Pod documented
22 92 ▶sub default_themes { return qw( core pbp bugs ) }
Subroutine default_themes: called CC=1 SCAR=0.0
Pod documented
23 37 ▶sub applies_to { return 'PPI::Token::Word' }
Subroutine applies_to: called CC=1 SCAR=0.0
Pod documented
24  
25 #-----------------------------------------------------------------------------
26  
27 sub violates {
28 361 ▶ my ($self, $elem, undef) = @_;
Subroutine violates: called CC=4 SCAR=23.7
Pod documented
29  
30 361 ▶ return if $elem->content() ne 'bless';
Branch: 1 branch
BranchTrueFalseTotal
if $elem->content ne "bless" 361 0 361
31 0 ▶ return if ! is_function_call($elem);
Branch: 1 branch
BranchTrueFalseTotal
unless is_function_call($elem) 0 0 0
32  
33 0 ▶ if( scalar parse_arg_list($elem) == 1 ) {
Branch: 1 branch
BranchTrueFalseTotal
if (scalar parse_arg_list($elem) == 1) 0 0 0
34 0 return $self->violation( $DESC, $EXPL, $elem );
35 }
36 0 return; #ok!
37 }
38  
39 40 1;
40  
41 #-----------------------------------------------------------------------------
42  
43 __END__
44  
45 =pod
46  
47 =head1 NAME
48  
49 Perl::Critic::Policy::ClassHierarchies::ProhibitOneArgBless - Write C<bless {}, $class;> instead of just C<bless {};>.
50  
51  
52 =head1 AFFILIATION
53  
54 This Policy is part of the core L<Perl::Critic|Perl::Critic>
55 distribution.
56  
57  
58 =head1 DESCRIPTION
59  
60 Always use the two-argument form of C<bless> because it allows
61 subclasses to inherit your constructor.
62  
63 sub new {
64 my $class = shift;
65 my $self = bless {}; # not ok
66 my $self = bless {}, $class; # ok
67 return $self;
68 }
69  
70  
71 =head1 CONFIGURATION
72  
73 This Policy is not configurable except for the standard options.
74  
75  
76 =head1 AUTHOR
77  
78 Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
79  
80 =head1 COPYRIGHT
81  
82 Copyright (c) 2005-2023 Imaginative Software Systems
83  
84 This program is free software; you can redistribute it and/or modify
85 it under the same terms as Perl itself.
86  
87 =cut
88  
89 # Local Variables:
90 # mode: cperl
91 # cperl-indent-level: 4
92 # fill-column: 78
93 # indent-tabs-mode: nil
94 # c-indentation-style: bsd
95 # End:
96 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
« blib/lib/Perl/Critic/Policy/Modules/RequireExplicitPackage.pm ↑ Summary blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitMixedBooleanOperators.pm »