blib/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitVoidMap.pm

filter: Statementstmt 90.0% 27 / 30 Branchbran 16.6% 1 / 6 Conditioncond n/a MC/DCmcdc n/a Subroutinesub 100% 11 / 11 Podpod 80.0% 4 / 5 totaltotal 82.6% 43 / 52 CC 4 SCAR 12.9
CC
4
Cov
78%
violates
10.2
BEGIN
1.0
BEGIN
1.0
CRAP 3.6
« blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitNoisyQuotes.pm ↑ Summary blib/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm »
1 package Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap;
2  
3 40 ▶use 5.010001;
Subroutine BEGIN: called CC=1 SCAR=0.0
4 40 ▶use strict;
Subroutine BEGIN: called CC=1 SCAR=0.0
5 40 ▶use warnings;
Subroutine BEGIN: called CC=1 SCAR=0.0
6 40 ▶use Readonly;
Subroutine BEGIN: called CC=1 SCAR=0.0
7  
8 40 ▶use Perl::Critic::Utils qw{ :severities :classification is_in_void_context };
Subroutine BEGIN: called CC=1 SCAR=0.0
9 40 ▶use parent 'Perl::Critic::Policy';
Subroutine BEGIN: called CC=1 SCAR=0.0
10  
11 40 our $VERSION = '1.150';
12  
13 #-----------------------------------------------------------------------------
14  
15 40 Readonly::Scalar my $DESC => q{"map" used in void context};
16 40 Readonly::Scalar my $EXPL => q{Use a "for" loop instead};
17  
18 #-----------------------------------------------------------------------------
19  
20 90 ▶sub supported_parameters { return () }
Subroutine supported_parameters: called CC=1 SCAR=0.0
Pod undocumented
21 75 ▶sub default_severity { return $SEVERITY_MEDIUM }
Subroutine default_severity: called CC=1 SCAR=0.0
Pod documented
22 74 ▶sub default_themes { return qw( core maintenance ) }
Subroutine default_themes: called CC=1 SCAR=0.0
Pod documented
23 31 ▶sub applies_to { return 'PPI::Token::Word' }
Subroutine applies_to: called CC=1 SCAR=0.0
Pod documented
24  
25 #-----------------------------------------------------------------------------
26  
27 sub violates {
28 332 ▶ my ( $self, $elem, undef ) = @_;
Subroutine violates: called CC=4 SCAR=23.2
Pod documented
29  
30 332 ▶ return if $elem->content() ne 'map';
Branch: 1 branch
BranchTrueFalseTotal
if $elem->content ne "map" 332 0 332
31 0 ▶ return if not is_function_call($elem);
Branch: 1 branch
BranchTrueFalseTotal
unless is_function_call($elem) 0 0 0
32 0 ▶ return if not is_in_void_context($elem);
Branch: 1 branch
BranchTrueFalseTotal
unless is_in_void_context($elem) 0 0 0
33  
34 0 return $self->violation( $DESC, $EXPL, $elem );
35 }
36  
37  
38 40 1;
39  
40 __END__
41  
42 #-----------------------------------------------------------------------------
43  
44 =pod
45  
46 =head1 NAME
47  
48 Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap - Don't use C<map> in void contexts.
49  
50  
51 =head1 AFFILIATION
52  
53 This Policy is part of the core L<Perl::Critic|Perl::Critic>
54 distribution.
55  
56  
57 =head1 DESCRIPTION
58  
59 C<map> and C<grep> are intended to be pure functions, not mutators.
60 If you want to iterate with side-effects, then you should use a proper
61 C<for> or C<foreach> loop.
62  
63 grep{ print frobulate($_) } @list; #not ok
64 print map{ frobulate($_) } @list; #ok
65  
66 grep{ $_ = lc $_ } @list; #not ok
67 for( @list ){ $_ = lc $_ }; #ok
68  
69 map{ push @frobbed, frobulate($_) } @list; #not ok
70 @frobbed = map { frobulate($_) } @list; #ok
71  
72  
73 =head1 CONFIGURATION
74  
75 This Policy is not configurable except for the standard options.
76  
77  
78 =head1 AUTHOR
79  
80 Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
81  
82  
83 =head1 COPYRIGHT
84  
85 Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
86  
87 This program is free software; you can redistribute it and/or modify
88 it under the same terms as Perl itself. The full text of this license
89 can be found in the LICENSE file included with this module.
90  
91 =cut
92  
93 # Local Variables:
94 # mode: cperl
95 # cperl-indent-level: 4
96 # fill-column: 78
97 # indent-tabs-mode: nil
98 # c-indentation-style: bsd
99 # End:
100 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
« blib/lib/Perl/Critic/Policy/ValuesAndExpressions/ProhibitNoisyQuotes.pm ↑ Summary blib/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm »