File Coverage

blib/lib/Perl/Critic/Policy/Mardem/ProhibitLargeBlock.pm

Criterion	Covered	Total	%
statement	40	42	95.2
branch	7	8	87.5
condition			n/a
subroutine	12	13	92.3
pod	4	5	80.0
total	63	68	92.6

use utf8;

use 5.010;

use strict;
use warnings;

our $VERSION = '0.04';

use Readonly;

use Perl::Critic::Utils qw{ :severities :data_conversion :classification };

use Perl::Critic::Mardem::Util qw( search_for_block_keyword );

use base 'Perl::Critic::Policy';

Readonly::Scalar my $EXPL => q{Consider refactoring};

{
    return $SEVERITY_MEDIUM;
}

{
    return qw(complexity maintenance);
}

{
    return 'PPI::Structure::Block';
}

{
    return (
        {   'name'            => 'statement_count_limit',
            'description'     => 'The maximum statement count allowed.',
            'default_string'  => '20',
            'behavior'        => 'integer',
            'integer_minimum' => 1,
        },
    );
}

{
    my ( $self, $elem, undef ) = @_;

    my $s = $elem->find( 'PPI::Statement' );

    if ( !$s ) {
        return;
    }

    my $statement_count = @{ $s };
    if ( $statement_count <= $self->{ '_statement_count_limit' } ) {
        return;
    }

    my $block_keyword = search_for_block_keyword( $elem );
    if ( !$block_keyword ) {
        $block_keyword = 'no-keyword-found';
    }

    if ( 'SUB' eq $block_keyword ) {
        return;    # no sub -> see SUB Perl::Critic::Policy::Mardem::ProhibitLargeSub !
    }

    my $desc = qq<"$block_keyword" code-block with high statement count ($statement_count)>;
    return $self->violation( $desc, $EXPL, $elem );
}

1;


#-----------------------------------------------------------------------------

=pod

=encoding utf8

=head1 NAME

Perl::Critic::Policy::Mardem::ProhibitLargeBlock

=head1 DESCRIPTION

This Policy counts the statements within a code block { ... }
(more precise the PPI::Statement's)

=head1 CONFIGURATION

The maximum acceptable Statement-Count can be set with the
C<statement_count_limit> configuration item. Any block with a count higher
than this number will generate a policy violation. The default is 20.

An example section for a F<.perlcriticrc>:

  [Mardem::ProhibitLargeBlock]
  statement_count_limit = 10

=head1 AFFILIATION

This policy is part of L<Perl::Critic::Mardem>.

=head1 AUTHOR

Markus Demml, [e-mail]

=head1 LICENSE AND COPYRIGHT

Copyright (c) 2022, Markus Demml

This library is free software; you can redistribute it and/or modify it
under the same terms as the Perl 5 programming language system itself.
The full text of this license can be found in the LICENSE file included
with this module.

=cut